-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: File type support for WF and API deployments #530
Conversation
|
Quality Gate passedIssues Measures |
] | ||
PREFERRED_BASE_ENV_KEYS = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chandrasekharan-zipstack Better to revert this change so that the run platform script always honor sample.env
and use its contents to override .env
.
This means we just need to ensure sample.env
is updated with new structure tool version each time, that's all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hari-kuriakose we always update the sample.env
with the latest structure tool version. However since we added these fields under PREFERRED_BASE_ENV_KEYS
-> during the merge of envs, we don't override the value already present in the user's .env
. As a result the user would always have an older version of structure tool present in their setup until and unless they manually check and update the value
What
.doc
and.docx
backend
alone, bumped it to0.0.34
merge_env.sh
scriptWhy
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Env Config
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.