Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed worker to runner everywhere #1055

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Renamed worker to runner everywhere #1055

merged 6 commits into from
Jan 8, 2025

Conversation

ritwik-g
Copy link
Contributor

@ritwik-g ritwik-g commented Jan 8, 2025

What

  • Renamed woker module to runner

Why

  • We had named celery workers as workers and this as runner

How

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

Database Migrations

Env Config

Relevant Docs

Related Issues or PRs

Dependencies Versions

Notes on Testing

Screenshots

Checklist

I have read and understood the Contribution Guidelines.

Copy link
Contributor

@muhammad-ali-e muhammad-ali-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hari-kuriakose hari-kuriakose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritwik-g LGTM overall

Copy link
Contributor

github-actions bot commented Jan 8, 2025

filepath function $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_logs}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup\_skip}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_client\_init}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image\_exists}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config\_without\_mount}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_run\_container}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{9}}$$ $$\textcolor{#23d18b}{\tt{9}}$$

Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ritwik-g ritwik-g merged commit ab24e7b into main Jan 8, 2025
4 checks passed
@ritwik-g ritwik-g deleted the rename-worker-to-runner branch January 8, 2025 07:35
@chandrasekharan-zipstack
Copy link
Contributor

chandrasekharan-zipstack commented Jan 9, 2025

@ritwik-g this might impact existing OSS users since the .env file needs to be moved from /worker to /runner
image

I hope they might be adept to carry this out on their own and we needn't handle it with some sort of a script.
And if its run with ./run-platform.sh I hope that the .env creation will be carried out automatically
cc: @hari-kuriakose

@ritwik-g
Copy link
Contributor Author

ritwik-g commented Jan 9, 2025

@ritwik-g this might impact existing OSS users since the .env file needs to be moved from /worker to /runner
image

I hope they might be adept to carry this out on their own and we needn't handle it with some sort of a script.
And if its run with ./run-platform.sh I hope that the .env creation will be carried out automatically
cc: @hari-kuriakose

@chandrasekharan-zipstack can you discuss this with team and consult @hari-kuriakose regarding this

@ritwik-g
Copy link
Contributor Author

ritwik-g commented Jan 9, 2025

@ritwik-g this might impact existing OSS users since the .env file needs to be moved from /worker to /runner
image

I hope they might be adept to carry this out on their own and we needn't handle it with some sort of a script.
And if its run with ./run-platform.sh I hope that the .env creation will be carried out automatically
cc: @hari-kuriakose

@chandrasekharan-zipstack also I don't think people would have changed any values for this. So if the script generates new env we should be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants