-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed worker to runner everywhere #1055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritwik-g LGTM overall
|
Quality Gate passedIssues Measures |
@ritwik-g this might impact existing OSS users since the I hope they might be adept to carry this out on their own and we needn't handle it with some sort of a script. |
@chandrasekharan-zipstack can you discuss this with team and consult @hari-kuriakose regarding this |
@chandrasekharan-zipstack also I don't think people would have changed any values for this. So if the script generates new env we should be good |
What
Why
workers
and this as runnerHow
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.