Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Client Endpoint Algorithim #7

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jrjena136
Copy link
Contributor

issue : Getting warning No Client EndPointIdentificationAlgorithm configured for SslContextFactory in log on server start up.

fix : As per the conversation here, it is mentioned that

if you are confident that you have no client behaviors, (direct Jetty HttpClient use? Http2Client use? Proxy usage? AsyncMiddleManServlet usage? WebSocketClient usage? JSR356 Client usage?) then feel free to ignore that warning.
Alternatively, you could make that warning go away by just declaring a EndPointIdentificationAlgorithm (such as HTTPS) on the SslContextFactory.setEndpointIdentificationAlgorithm(String)

need to check with @rupalid is there any client behavior which could be effected due to this change. otherwise we can use HTTPS as the default endpoint algorithm to avoid the warning.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants