Fixed DwtBaseDialog._initializeDragging offset #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the initialization of the dragging of the DwtBaseDialog a wrong offset was calculated resulting in a dialog locked with Y=0 and X movable. This patch initialize the correct boundaries to let the dialog to be dragged everywhere in the window. How to reproduce: - Open the admin console - Popup a dialog, Your choice - Click on the title bar of the dialog and drag the dialog What happens: - The dialog is moved on the top of the window and can slide only in X coordinates Expected: - The dialog must follow the mouse movements
|
|
silentsakky
requested review from
silentsakky,
kalpeshhpatel,
swapnilpingle89 and
miteshsavani
|
@bud-mo admin console is using zm-admin-ajax, can we move this fix to that repo? |
|
@silentsakky Yes sure, Do You prefer I create another pull-request or You can move that fix? |
|
It would be better if you can make the changes in repo and test it then you can create a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.zimbra.com/show_bug.cgi?id=103201
During the initialization of the dragging of the DwtBaseDialog a wrong offset was calculated resulting in a dialog locked with Y=0 and X movable.
This patch initialize the correct boundaries to let the dialog to be dragged everywhere in the window.
How to reproduce:
What happens:
Expected: