Feature/zcs 6046 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srivastava-ami
requested review from
gordyt,
tmclane,
fatkudu,
rupalid and
Prashantsurana
|
Shouldn't the target branch be develop? |
fatkudu
suggested changes
Sep 26, 2018
def/package-UBUNTU.def
Outdated
| @@ -1,5 +1,10 @@ | |||
| include $(DEF_ROOT)/package-deb.def | |||
|
|
|||
| PKG_APPEND.UBUNTU16_64 := .18.04 | |||
There was a problem hiding this comment.
Looks wrong. Surely PKG_APPEND.UBUNTU18_64?
def/package-UBUNTU.def
Outdated
| PKG_APPEND.UBUNTU16_64 := .16.04 | ||
| PKG_APPEND.UBUNTU14_64 := .14.04 | ||
| PKG_APPEND.UBUNTU12_64 := .12.04 | ||
| PKG_OS_TAG.UBUNTU16_64 := u18 |
There was a problem hiding this comment.
Again looks wrong - assume should be PKG_OS_TAG.UBUNTU18_64
srivastava-ami
force-pushed
the
feature/ZCS-6046
branch
from
e69c736
to
1cd0124
Compare
…M/DEB release tag
…tub into feature/ZCS-6046
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and approve.