Fix incorrect font-weight mapping based on Mozilla documentation #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e mapping for CSS font-weight values.
zhgchgli0718
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to fix the incorrect mapping of
font-weightvalues in theswitchstatement. The original implementation had an issue whereUIFont.Weight.medium.rawValuewould incorrectly map to a bold weight due to the raw value being0.23000000417232513.Changes
switchstatement to map thefont-weightvalues correctly based on Mozilla's documentation (MDN Web Docs).Why this is important
The issue can cause unexpected behavior in text rendering, especially when comparing
UIFont.Weight.medium.rawValueandweight.rawValue.Test Plan
font-weightvalues against Mozilla's documentation.font-weightvalues.Checklist