[Feat] code format & using CSSProperty wrapper #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
5anniversary
commented
Jul 31, 2023
5anniversary
commented
- Added the ability to add a font family type.
|
Hello, thank you for your PR contribution. Regarding the implementation of font-family, I have already implemented it in PR #29 (taking into account the various cases of CSS font-family and matching with UIFont/NSFont Family). I will adjust the Code Format and CSSProperty contributions from your PR, extract them, and then merge them. Thank you again for your contribution. |
zhgchgli0718
changed the title
Closed
|
Fixed a conflict |
|
@zhgchgli0718 |
|
I had some code I wanted to add, so I added it and raised it to a new PR! And I'll close this PR!!! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.