Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(train): use gpu type arg for workers; group tail_lines logs #918

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akhileshh
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a6bcbae) to head (79592ea).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #918   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          142       145    +3     
  Lines         6113      6129   +16     
=========================================
+ Hits          6113      6129   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

logger.info("\n".join(result))
if len(result) == tail_lines:
logger.info("\n".join(result))
result = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there supposed to be a final logger.info("\n".join(result)) at the end for when len(log_stream) is not evenly divisible by 8?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or does tail lines always give you what you asked, but then there's possibly a long delay between the actual output and when you see it.

Copy link
Contributor

@trivoldus28 trivoldus28 Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd set the default to None for now I think.

edit1: oh nvm I meant for training.py but I see you removed it already

edit2: ah but the default = 8 here would still enable it.

Copy link
Contributor Author

@akhileshh akhileshh Feb 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or does tail lines always give you what you asked, but then there's possibly a long delay between the actual output and when you see it.

Yeah its a blocking call that just polls for logs. I have now made it a param to training so user can decide.

@akhileshh akhileshh force-pushed the akhilesh/gputype-workers branch from 203fffe to 79592ea Compare February 22, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants