-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(train): use gpu type arg for workers; group tail_lines logs #918
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 142 145 +3
Lines 6113 6129 +16
=========================================
+ Hits 6113 6129 +16 ☔ View full report in Codecov by Sentry. |
logger.info("\n".join(result)) | ||
if len(result) == tail_lines: | ||
logger.info("\n".join(result)) | ||
result = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there supposed to be a final logger.info("\n".join(result))
at the end for when len(log_stream)
is not evenly divisible by 8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or does tail lines always give you what you asked, but then there's possibly a long delay between the actual output and when you see it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd set the default to None
for now I think.
edit1: oh nvm I meant for training.py
but I see you removed it already
edit2: ah but the default = 8 here would still enable it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or does tail lines always give you what you asked, but then there's possibly a long delay between the actual output and when you see it.
Yeah its a blocking call that just polls for logs. I have now made it a param to training so user can decide.
203fffe
to
79592ea
Compare
No description provided.