Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cluster creation and install script #887

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nkemnitz
Copy link
Collaborator

@nkemnitz nkemnitz commented Feb 5, 2025

  • system node e2-medium -> e2-standard-2, remove manual CPU request overrides
  • keep e2-medium, but enable autoscaling for system nodes (to host the additional kube-dns and konnectivity pods)
  • include helm in zutils install (required for KEDA setup when creating new clusters)

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a01d363) to head (22574c1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #887   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          142       142           
  Lines         6113      6113           
=========================================
  Hits          6113      6113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akhileshh
Copy link
Contributor

Looks good, but any reason to explicitly set --max-pods-per-node "32" ? The default is 110, what are the benefits of limiting it to 32?

@nkemnitz
Copy link
Collaborator Author

nkemnitz commented Feb 5, 2025

That's just a habit from old days where we had thousands of nodes running and would exhaust the IP address ranges, iirc - so actually more relevant to the worker node pools than the system node pool

Copy link
Member

@supersergiy supersergiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add more node pools to these clusters, like we have on zetta-research?

@nkemnitz nkemnitz force-pushed the nkem/update-cluster-create branch from a0a09c6 to 102a165 Compare February 6, 2025 13:56
@nkemnitz nkemnitz force-pushed the nkem/update-cluster-create branch from 102a165 to 22574c1 Compare February 17, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants