-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cluster creation and install script #887
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 142 142
Lines 6113 6113
=========================================
Hits 6113 6113 ☔ View full report in Codecov by Sentry. |
Looks good, but any reason to explicitly set |
That's just a habit from old days where we had thousands of nodes running and would exhaust the IP address ranges, iirc - so actually more relevant to the worker node pools than the system node pool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add more node pools to these clusters, like we have on zetta-research
?
a0a09c6
to
102a165
Compare
102a165
to
22574c1
Compare
system node e2-medium -> e2-standard-2, remove manual CPU request overrideskube-dns
andkonnectivity
pods)