Use cloudpickle for id_generation instead of dill #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dodamih
force-pushed
the
dodam/recursion_debug
branch
2 times, most recently
from
4dc4c8f to
c1ab0df
Compare
dodamih
force-pushed
the
dodam/recursion_debug
branch
from
c1ab0df to
ba3d718
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #859 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 142 142
Lines 6031 6036 +5
===========================================
+ Hits 6031 6035 +4
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Sergiy and I investigated dill id_generation recursion bug, we found that there's issues coming from zetta_utils importing internal, which imports zetta_utils. Switching to cloudpickle for id_generation seems to fix this issue.