Update Porting-Lib to newer versions & fix Maven deps to fix crashes on launch with newer versions of Porting Lib #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll give it a look at some point when I have time! I've unfortunately not had much recently :( |
|
Absolutely understandable, no rush! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya - I've spent my morning today sorting out the changes in Porting-Lib's maven URLs as well as one of its dependency's changes. This PR fixes "Crashes on launch with newer versions of Porting Lib #11".
To be honest, this is my first time doing anything with Fabric on the dev side -- I've been dev'ing on Forge (and ModLoader before that) for over a decade, so if I made any mistakes, let me know!
This PR also fixes the change in Maven URLs for
cardinal-componentsand preemptively grabsreach-entity-attributes, which is required by Porting-Lib (which uses an out-of-date Maven URL too). Seems like Maven URL consistency is a hot commodity in Fabric's modding community 😅