Skip to content

Commit

Permalink
update 18.9.0 (bttv-android#687)
Browse files Browse the repository at this point in the history
  • Loading branch information
FoseFx authored Aug 30, 2024
1 parent 2cd057d commit 403bc13
Show file tree
Hide file tree
Showing 68 changed files with 381 additions and 461 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
# set env variables
- name: set variables
run: |
echo "APK_URL https://www.dropbox.com/scl/fi/8m7pwt6nk1y6qm05e39cg/twitch-18.0.0.apk\?rlkey=amczmm56hkmp5cbd2blwjb6bw\&st=c8ic93h1\&dl=1" >> $GITHUB_ENV
echo "APK_URL=https://www.dropbox.com/scl/fi/1fglq3uupo5j87ox7v3e0/twitch-18.9.0.apk\?rlkey=tjw6kdq0ynplycprjbtgr1u2a\&st=cce58kkj\&dl=1" >> $GITHUB_ENV
# get keystore.kjs from secret
- name: create keystore.kjs from secret
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Changelog

# master
- rebase to v17.0.0
- rebase to v18.9.0

# 0.41.0-beta
- rebase to v16.9.1
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ A mod of the Twitch Android Mobile<sup><a href="#no-tv">1</a></sup> App adding B

# Build it yourself

> This patch is meant to be applied to version **18.0.0** of the official twitch app
> This patch is meant to be applied to version **18.9.0** of the official twitch app
> Make sure you use this version before you create an issue!
## Easy way: Docker
Expand Down Expand Up @@ -128,7 +128,7 @@ Made with ♥️ by [@FoseFx](https://github.com/FoseFx) and contributors. MIT L
[license-badge]: https://img.shields.io/github/license/bttv-android/bttv?style=flat-square
[license-file]: ./LICENSE
[bttv-version]: https://img.shields.io/github/v/release/bttv-android/bttv?style=flat-square
[base-version]: https://img.shields.io/badge/build%20on-v18.0.0-blueviolet?style=flat-square
[base-version]: https://img.shields.io/badge/build%20on-v18.9.0-blueviolet?style=flat-square
[downloads-latest]: https://img.shields.io/github/downloads/bttv-android/bttv/latest/total?color=yellow&style=flat-square
[downloads-total]: https://img.shields.io/github/downloads/bttv-android/bttv/total?color=yellowgreen&label=downloads%20total&style=flat-square
[latest-release]: https://github.com/bttv-android/bttv/releases/latest
Expand Down
4 changes: 2 additions & 2 deletions genmonke
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ mv tv.twitch.android.shared.chat.observables.ChatConnectionController.smali.patc
mkdir stream-settings
mv res.layout.stream_settings_fragment.xml.patch stream-settings/.
mv tv.twitch.android.feature.theatre.common.StreamSettingsViewDelegate.smali.patch stream-settings/.
mv res.layout-v22.stream_settings_fragment.xml.patch stream-settings/.


# Glide Modules
Expand Down Expand Up @@ -93,11 +94,10 @@ mv tv.twitch.android.shared.emotes.emotepicker.EmotePickerPresenter.smali.patch

# Settings
mkdir settings
mv 'tv.twitch.android.app.consumer.dagger.DaggerAppComponent$AppComponentImpl.smali.patch' settings/.
mv 'tv.twitch.android.app.consumer.dagger.DaggerAppComponent$SettingsActivitySubcomponentImpl.smali.patch' settings/.
mv 'tv.twitch.android.shared.ui.menus.SettingsPreferencesController$SettingsPreference.smali.patch' settings/.
mv tv.twitch.android.models.settings.SettingsDestination.smali.patch settings/.
mv tv.twitch.android.settings.* settings/.
mv tv.twitch.android.app.consumer.DaggerTwitchApplication_HiltComponents_SingletonC\$ActivityCImpl.smali.patch settings/.

# Settings bottom
mkdir settings-bottom
Expand Down
13 changes: 3 additions & 10 deletions mod/app/src/main/java/bttv/ChommentModelDelegateWrapper.java
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,9 @@
import javax.inject.Provider;

import bttv.highlight.Highlight;
import tv.twitch.android.shared.chat.ChatMessageParserSdk;
import tv.twitch.android.shared.chat.pub.model.messages.MessageToken;
import tv.twitch.android.models.chomments.ChommentModel;
import tv.twitch.android.shared.chat.pub.model.ChatMessageTokenizerWrapper;
import tv.twitch.android.provider.experiments.ExperimentHelper;
import tv.twitch.android.sdk.SDKServicesController;
import tv.twitch.android.shared.chat.ChatMessageParser;
import tv.twitch.android.shared.chat.chomments.ChommentModelDelegate;

Expand All @@ -23,16 +20,12 @@ public class ChommentModelDelegateWrapper extends ChommentModelDelegate {
private Boolean BTTVshouldHighlightB = null;

public ChommentModelDelegateWrapper(ChommentModel chommentModel,
Provider<ChatMessageParserSdk> chatMessageParserSdkProvider,
Provider<tv.twitch.android.shared.chat.ChatMessageParser> chatMessageParserProvider,
ChatMessageTokenizerWrapper chatMessageTokenizerWrapper,
tv.twitch.android.shared.chat.KmpChatExperiment kpmChatExperiment) {
Provider<ChatMessageParser> chatMessageParserProvider,
ChatMessageTokenizerWrapper chatMessageTokenizerWrapper) {
super(
chommentModel,
chatMessageParserSdkProvider,
chatMessageParserProvider,
chatMessageTokenizerWrapper,
kpmChatExperiment
chatMessageTokenizerWrapper
);
}

Expand Down
4 changes: 2 additions & 2 deletions mod/app/src/main/java/bttv/settings/SettingsFragment.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

import javax.inject.Inject;
import android.util.Log;
import tv.twitch.android.settings.base.BaseSettingsFragment;
import tv.twitch.android.settings.base.BaseSettingsPresenter;
import tv.twitch.android.shared.settings.BaseSettingsFragment;
import tv.twitch.android.shared.settings.BaseSettingsPresenter;

public class SettingsFragment extends BaseSettingsFragment {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,77 +1,46 @@
package bttv.settings;

import javax.inject.Provider;

import android.util.Log;
import androidx.fragment.app.FragmentActivity;
import tv.twitch.android.app.core.dagger.modules.ActivityModule;
import tv.twitch.android.app.core.dagger.modules.ActivityModule_ProvideMenuAdapterBinderFactory;
import tv.twitch.android.settings.base.SettingsTracker;
import tv.twitch.android.settings.dagger.SettingsActivityModule;
import tv.twitch.android.settings.dagger.SettingsActivityModule_ProvideSettingsTrackerFactory;
import tv.twitch.android.shared.analytics.PageViewTracker;
import tv.twitch.android.shared.settings.SettingsTracker;
import tv.twitch.android.shared.ui.menus.core.MenuAdapterBinder;

public class SettingsFragmentBindingFactory implements SettingsFragmentBinding.Factory {

private static Provider<FragmentActivity> fragmentActivityProvider;
private static Provider<PageViewTracker> pageViewTrackerProvider;
private static ActivityModule activityModule;
private static SettingsActivityModule settingsActivityModule;

public static void setFragmentActivityProvider(Provider<FragmentActivity> fragmentActivityProvider) {
SettingsFragmentBindingFactory.fragmentActivityProvider = fragmentActivityProvider;
Log.d("LBTTVDI", "got fragmentActivityProvider");
}

public static void setActivityModule(ActivityModule activityModule) {
SettingsFragmentBindingFactory.activityModule = activityModule;
Log.d("LBTTVDI", "got activityModule");
}

public static void setSettingsActivityModule(SettingsActivityModule activityModule) {
SettingsFragmentBindingFactory.settingsActivityModule = activityModule;
Log.d("LBTTVDI", "got settingsActivityModule");
}
private static FragmentActivity fragmentActivity; // TODO ;fragmentActivityProvider.get();
private static MenuAdapterBinder menuAdapterBinder; // TODO;
private static SettingsTracker settingsTracker; // TODO;

public static void setPageViewTrackerProvider(Provider<PageViewTracker> pageViewTrackerProvider) {
SettingsFragmentBindingFactory.pageViewTrackerProvider = pageViewTrackerProvider;
Log.d("LBTTVDI", "got pageViewTrackerProvider");
/** @noinspection unused */
public static void setFragmentActivity(Object fragmentActivity) {
Log.d("LBTTVDI", "got fragmentActivity: " + fragmentActivity.getClass().getName());
SettingsFragmentBindingFactory.fragmentActivity = (FragmentActivity) fragmentActivity;
}

private static MenuAdapterBinder getMenuAdapterBinder() {
return ActivityModule_ProvideMenuAdapterBinderFactory.provideMenuAdapterBinder(
SettingsFragmentBindingFactory.activityModule,
SettingsFragmentBindingFactory.fragmentActivityProvider.get());
/** @noinspection unused */
public static void setMenuAdapterBinder(MenuAdapterBinder menuAdapterBinder) {
SettingsFragmentBindingFactory.menuAdapterBinder = menuAdapterBinder;
Log.d("LBTTVDI", "got menuAdapterBinder");
}

private static SettingsTracker getTracker() {
return SettingsActivityModule_ProvideSettingsTrackerFactory.provideSettingsTracker(
SettingsFragmentBindingFactory.settingsActivityModule, pageViewTrackerProvider.get());
/** @noinspection unused */
public static void setSettingsTracker(SettingsTracker settingsTracker) {
SettingsFragmentBindingFactory.settingsTracker = settingsTracker;
Log.d("LBTTVDI", "got settingsTracker");
}

@Override
public SettingsFragmentBinding create(SettingsFragment fragment) {
if (fragmentActivityProvider == null) {
Log.e("LBTTVDI", "fragmentActivityProvider null");
return null;
}
if (activityModule == null) {
Log.e("LBTTVDI", "activityModule null");
return null;
if (fragmentActivity == null) {
Log.e("LBTTV", "SettingsFragmentBinding.create will fail: fragmentActivity == null");
}
if (settingsActivityModule == null) {
Log.e("LBTTVDI", "settingsActivityModule null");
return null;
if (menuAdapterBinder == null) {
Log.e("LBTTV", "SettingsFragmentBinding.create will fail: menuAdapterBinder == null");
}
if (pageViewTrackerProvider == null) {
Log.e("LBTTVDI", "pageViewTrackerProvider null");
return null;
if (settingsTracker == null) {
Log.e("LBTTV", "SettingsFragmentBinding.create will fail: settingsTracker == null");
}

FragmentActivity activity = fragmentActivityProvider.get();

return new SettingsFragmentBindingImpl(fragment, activity, getMenuAdapterBinder(), getTracker());
return new SettingsFragmentBindingImpl(fragment, fragmentActivity, menuAdapterBinder, settingsTracker);
}

}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package bttv.settings;

import androidx.fragment.app.FragmentActivity;
import tv.twitch.android.settings.base.SettingsTracker;
import tv.twitch.android.shared.settings.SettingsTracker;
import tv.twitch.android.shared.ui.menus.core.MenuAdapterBinder;

public class SettingsFragmentBindingImpl implements SettingsFragmentBinding {
Expand Down
6 changes: 3 additions & 3 deletions mod/app/src/main/java/bttv/settings/SettingsPresenter.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
import tv.twitch.android.core.adapters.HeaderConfig;
import tv.twitch.android.core.adapters.SectionHeaderDisplayConfig;
import tv.twitch.android.models.settings.SettingsDestination;
import tv.twitch.android.settings.base.BaseSettingsPresenter;
import tv.twitch.android.settings.base.SettingsNavigationController;
import tv.twitch.android.settings.base.SettingsTracker;
import tv.twitch.android.shared.settings.BaseSettingsPresenter;
import tv.twitch.android.shared.settings.SettingsNavigationController;
import tv.twitch.android.shared.settings.SettingsTracker;
import tv.twitch.android.shared.ui.menus.SettingsPreferencesController;
import tv.twitch.android.shared.ui.menus.core.MenuAdapterBinder;
import tv.twitch.android.shared.ui.menus.core.MenuModel;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package tv.twitch.android.app.consumer.dagger;

public class ActivityModule {

}
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package tv.twitch.android.app.core.dagger.modules;
package tv.twitch.android.app.consumer.dagger;

import androidx.fragment.app.FragmentActivity;

import tv.twitch.android.shared.ui.menus.core.MenuAdapterBinder;

public class ActivityModule_ProvideMenuAdapterBinderFactory {
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package tv.twitch.android.settings.dagger;

import tv.twitch.android.settings.base.SettingsTracker;
import tv.twitch.android.shared.settings.SettingsTracker;
import tv.twitch.android.shared.analytics.PageViewTracker;

public class SettingsActivityModule_ProvideSettingsTrackerFactory {
public final class SettingsActivityModule_ProvideSettingsTrackerFactory {
public static SettingsTracker provideSettingsTracker(SettingsActivityModule a, PageViewTracker t) {
return null;
}
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,8 @@
public class ChommentModelDelegate implements ChatMessageInterface {

public ChommentModelDelegate(ChommentModel chommentModel,
Provider<tv.twitch.android.shared.chat.ChatMessageParserSdk> chatMessageParserSdkProvider,
Provider<tv.twitch.android.shared.chat.ChatMessageParser> chatMessageParserProvider,
ChatMessageTokenizerWrapper chatMessageTokenizerWrapper,
tv.twitch.android.shared.chat.KmpChatExperiment kpmChatExperiment) {
ChatMessageTokenizerWrapper chatMessageTokenizerWrapper) {
}

@Override
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package tv.twitch.android.settings.base;
package tv.twitch.android.shared.settings;

public abstract class BaseSettingsFragment {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
package tv.twitch.android.settings.base;
package tv.twitch.android.shared.settings;

import java.util.List;

import androidx.fragment.app.FragmentActivity;

import tv.twitch.android.shared.ui.menus.SettingActionListener;
import tv.twitch.android.shared.ui.menus.SettingsPreferencesController;
import tv.twitch.android.shared.ui.menus.core.MenuAdapterBinder;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package tv.twitch.android.settings.base;
package tv.twitch.android.shared.settings;

import android.os.Bundle;

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package tv.twitch.android.shared.settings;

public class SettingsTracker {

}
14 changes: 7 additions & 7 deletions patches/AndroidManifest.xml.patch
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ diff --git a/AndroidManifest.xml b/AndroidManifest.xml
+<?xml version="1.0" encoding="utf-8" standalone="no"?>
+<manifest
+ xmlns:android="http://schemas.android.com/apk/res/android"
+ android:versionCode="${BTTVVERSIONCODE}"
+ android:versionName="${BTTVVERSION}"
+ android:versionCode="01208000334"
+ android:versionName="0.41.0-beta"
+ android:compileSdkVersion="34"
+ android:compileSdkVersionCodename="14"
+ android:installLocation="auto"
Expand Down Expand Up @@ -37,7 +37,7 @@ diff --git a/AndroidManifest.xml b/AndroidManifest.xml
<uses-permission android:name="com.google.android.finsky.permission.BIND_GET_INSTALL_REFERRER_SERVICE"/>
<application android:allowBackup="false" android:appComponentFactory="androidx.core.app.CoreComponentFactory" android:enabled="true" android:extractNativeLibs="true" android:icon="@mipmap/ic_launcher" android:label="@string/app_name" android:largeHeap="true" android:name="tv.twitch.android.app.consumer.TwitchApplication" android:networkSecurityConfig="@xml/default_security_config" android:requestLegacyExternalStorage="false" android:supportsRtl="true" android:theme="@style/Theme.TwitchApp">
<profileable android:shell="true"/>
@@ -178,15 +190,15 @@
@@ -175,15 +187,15 @@
<action android:name="android.intent.action.MEDIA_BUTTON"/>
</intent-filter>
</service>
Expand All @@ -56,16 +56,16 @@ diff --git a/AndroidManifest.xml b/AndroidManifest.xml
<meta-data android:name="io.branch.sdk.BranchKey" android:value="key_live_jgBdao5vVtyZ3hdckxy8jlkkzqooQltZ"/>
<meta-data android:name="io.branch.sdk.BranchKey.test" android:value="key_test_ahupan1EKvF7XkpepyA3vpfivrdlOlMg"/>
<meta-data android:name="io.branch.sdk.TestMode" android:value="false"/>
@@ -296,7 +308,7 @@
@@ -298,7 +310,7 @@
</service>
<activity android:exported="false" android:name="com.google.android.gms.common.api.GoogleApiActivity" android:theme="@android:style/Theme.Translucent.NoTitleBar"/>
<meta-data android:name="com.bumptech.glide.integration.okhttp3.OkHttpGlideModule" android:value="GlideModule"/>
<service android:enabled="true" android:exported="false" android:name="com.google.firebase.sessions.SessionLifecycleService"/>
- <provider android:authorities="tv.twitch.android.app.firebaseinitprovider" android:directBootAware="true" android:exported="false" android:initOrder="100" android:name="com.google.firebase.provider.FirebaseInitProvider"/>
+ <provider android:authorities="tv.twitch.bttvandroid.app.firebaseinitprovider" android:directBootAware="true" android:exported="false" android:initOrder="100" android:name="com.google.firebase.provider.FirebaseInitProvider"/>
<meta-data android:name="com.google.android.gms.version" android:value="@integer/google_play_services_version"/>
<uses-library android:name="androidx.window.extensions" android:required="false"/>
<uses-library android:name="androidx.window.sidecar" android:required="false"/>
@@ -354,5 +366,18 @@
<meta-data android:name="com.google.android.gms.version" android:value="@integer/google_play_services_version"/>
@@ -356,5 +368,18 @@
</intent-filter>
</receiver>
<service android:exported="true" android:name="com.amazonaws.ivs.player.AnalyticsService" android:permission="android.permission.BIND_JOB_SERVICE"/>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
diff --git a/smali_classes6/tv/twitch/android/shared/chat/ChatViewPresenter.smali b/smali_classes6/tv/twitch/android/shared/chat/ChatViewPresenter.smali
--- a/smali_classes6/tv/twitch/android/shared/chat/ChatViewPresenter.smali
+++ b/smali_classes6/tv/twitch/android/shared/chat/ChatViewPresenter.smali
@@ -36,7 +36,7 @@
@@ -34,7 +34,7 @@

.field private final buildConfigUtil:Ltv/twitch/android/core/buildconfig/BuildConfigUtil;

Expand All @@ -10,7 +10,7 @@ diff --git a/smali_classes6/tv/twitch/android/shared/chat/ChatViewPresenter.smal

.field private channelInfo:Ltv/twitch/chat/library/model/ChatChannelInfo;

@@ -76,7 +76,7 @@
@@ -72,7 +72,7 @@

.field private chatConnectDisposable:Lio/reactivex/disposables/Disposable;

Expand All @@ -19,7 +19,7 @@ diff --git a/smali_classes6/tv/twitch/android/shared/chat/ChatViewPresenter.smal

.field private final chatDialogRouter:Ltv/twitch/android/shared/chat/pub/ChatDialogRouter;

@@ -1563,6 +1563,10 @@
@@ -1557,6 +1557,10 @@

iput-object v1, v0, Ltv/twitch/android/shared/chat/ChatViewPresenter;->messageInputListener:Ltv/twitch/android/shared/chat/ChatViewPresenter$messageInputListener$1;

Expand All @@ -30,7 +30,7 @@ diff --git a/smali_classes6/tv/twitch/android/shared/chat/ChatViewPresenter.smal
return-void
.end method

@@ -2173,6 +2177,13 @@
@@ -2122,6 +2126,13 @@
:cond_0
return-void
.end method
Expand Down
Loading

0 comments on commit 403bc13

Please sign in to comment.