Fix tvdbcount #539
Merged
Fix tvdbcount #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdbcount should be calculated in the second, full loop. Also piggybacking off the collection array, no need for a separate dict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tvdbcount should be calculated in the second, full loop. Since we're already collecting repeated TVDBids, just counted length of that array instead of using another dict.
This should now fix the issue of tvdbcount not incrementing properly as mentioned in issue #538; however, this still doesn't seem to fix the issue of HAMA always forcibly mapping specials to TVDB.