Remove dependency on ring_algorithm crate
#125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
survived
force-pushed
the
remove-ring-alg
branch
2 times, most recently
from
91156b2
to
957a29f
Compare
survived
force-pushed
the
remove-ring-alg
branch
from
8c9172e
to
569eabe
Compare
omershlo
reviewed
Aug 5, 2021
src/arithmetic/big_native/ring.rs
Outdated
| @@ -0,0 +1,93 @@ | |||
| // Taken from: https://gitlab.com/Toru3/ring-algorithm/-/blob/c4eaf606e88cb62cf87df98c99f923b253ad976a/src/lib.rs | |||
There was a problem hiding this comment.
I suggest to rename this file ring-algorithms
|
FWIW this won't be needed after I finish #121 (assuming we'll merge it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency on
ring-algorithmcrate was removed. Very few functions from that crate which were used incurvare copypasted (original code is licensed underMIT OR Apache-2.0) to dedicated module as a drop-in replacement.Fixes #124