Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZO-4267: postgresql connector copy move lock #632

Merged
merged 24 commits into from
Mar 8, 2024
Merged

ZO-4267: postgresql connector copy move lock #632

merged 24 commits into from
Mar 8, 2024

Conversation

stollero
Copy link
Contributor

@stollero stollero commented Feb 26, 2024 •
edited
Loading

Checklist

gif

@louika louika force-pushed the ZO-4267_connector_copy_move_lock branch from 9c410c8 to 667abbc Compare February 28, 2024 14:10
@stollero stollero force-pushed the ZO-4267_connector_copy_move_lock branch from 93fa897 to 990c074 Compare February 29, 2024 07:13
@louika louika force-pushed the ZO-4267_connector_copy_move_lock branch from 56ccc0f to 49a61ca Compare March 1, 2024 10:57
wosc
wosc requested changes Mar 1, 2024
View reviewed changes
core/src/zeit/connector/testing.py Show resolved Hide resolved
core/src/zeit/connector/postgresql.py Outdated Show resolved Hide resolved
core/src/zeit/connector/connector.py Show resolved Hide resolved
core/src/zeit/connector/connector.py Show resolved Hide resolved
core/src/zeit/connector/postgresql.py Outdated Show resolved Hide resolved
core/src/zeit/connector/postgresql.py Show resolved Hide resolved
core/src/zeit/connector/postgresql.py Outdated Show resolved Hide resolved
core/src/zeit/connector/filesystem.py Show resolved Hide resolved
core/src/zeit/connector/postgresql.py Outdated Show resolved Hide resolved
core/src/zeit/connector/connector.py Outdated Show resolved Hide resolved
@louika louika force-pushed the ZO-4267_connector_copy_move_lock branch 3 times, most recently from a2c4257 to e2be8d7 Compare March 1, 2024 15:25
@stollero stollero marked this pull request as ready for review March 4, 2024 07:10
@stollero stollero force-pushed the ZO-4267_connector_copy_move_lock branch 4 times, most recently from 7b4e4c9 to 1dbe8cd Compare March 4, 2024 09:56
@stollero stollero requested a review from wosc March 4, 2024 10:28
@stollero stollero force-pushed the ZO-4267_connector_copy_move_lock branch 4 times, most recently from 95f723f to 47745f9 Compare March 5, 2024 10:45
wosc
wosc requested changes Mar 5, 2024
View reviewed changes
core/src/zeit/connector/connector.py Outdated Show resolved Hide resolved
core/src/zeit/connector/postgresql.py Outdated Show resolved Hide resolved
core/src/zeit/connector/postgresql.py Show resolved Hide resolved
core/src/zeit/connector/postgresql.py Outdated Show resolved Hide resolved
core/src/zeit/connector/postgresql.py Show resolved Hide resolved
core/src/zeit/connector/postgresql.py Outdated Show resolved Hide resolved
core/src/zeit/connector/postgresql.py Show resolved Hide resolved
core/src/zeit/connector/postgresql.py Show resolved Hide resolved
core/src/zeit/connector/postgresql.py Outdated Show resolved Hide resolved
wosc and others added 12 commits March 6, 2024 15:06
@wosc @louika
MAINT: Simplify spelling with from-import
3ce53a9
@wosc @louika
MAINT: Prepare more consistent spelling for upcoming "not exists" case
37ecf88
@wosc @louika
ZO-4267: Extract recursive treatment of child ids into helper method,…
2a39dda 
… so we can reuse it
@stollero @louika
ZO-4267: update contract test for move, delete and list collection
3ec5e6f 
Co-authored-by:  Louisa v. Hülsen <[email protected]>
@wosc @louika
ZO-4267: Conform to contract: remove delete children from cache
6e0d265
@louika
ZO-4267: Add changelog
898b438
@stollero @louika
ZO-4267: change in connector contract: move to existing resource sho…
05bd284 
…uld not work

we can think about a force parameter that a user knows what they are doing but the overwrite should not be based on just a body comparison

Co-authored-by:  Louisa v. Hülsen <[email protected]>
@stollero @louika
ZO-4267: connector method listCollection should throw generic KeyErr…
b3776bf 
…or instead of DAVNotFoundError for all connectors

Co-authored-by:  Louisa v. Hülsen <[email protected]>
@stollero @louika
ZO-4267: support dict and list params for sql tracing
381ea6d 
Co-authored-by:  Louisa v. Hülsen <[email protected]>
@stollero @louika
ZO-4267: ignore uuid checks for mock connector
8f9b891 
Co-authored-by:  Louisa v. Hülsen <[email protected]>
@stollero @louika
ZO-4267: map dav failed dependency error to exception
c5eb4a1 
convert into generic connector exception to be able to define a contract for all connectors

Co-authored-by:  Louisa v. Hülsen <[email protected]>
@stollero @louika
ZO-4267: update documentation for connector interface
69c7818 
Co-authored-by:  Louisa v. Hülsen <[email protected]>
stollero and others added 8 commits March 6, 2024 15:06
@stollero @louika
ZO-4267: make sure the the dav connector recursively clean ups any locks
f4771c5 
... and fails if delete or unlock throws exception to avoid any test isolation problems

Co-authored-by:  Louisa v. Hülsen <[email protected]>
@stollero @louika
ZO-4267: rename Paths and Properties to Path and Content
c101999 
- singular is commonly used
- Name Content is more appropriate because we have the attributes and bodies of the content object inside this table
- should not affect raw SQL, only class names and relationship name used with sqlalchemy

Co-authored-by:  Louisa v. Hülsen <[email protected]>
@stollero @louika
ZO-4267: raise KeyError instead of DAVNotFoundError for listCollectio…
b0eac4f 
…n in postgresql connector

Co-authored-by:  Louisa v. Hülsen <[email protected]>
@stollero @louika
ZO-4267: implement copy for postgresql connector
f9b7032 
Co-authored-by:  Louisa v. Hülsen <[email protected]>
@stollero @louika
ZO-4267: implement move for postgresql connector
fbcfb27 
Co-authored-by:  Louisa v. Hülsen <[email protected]>
@stollero @louika
ZO-4267: implement lock, unlocked and locked for postgresql connector
f09684e 
Co-authored-by:  Louisa v. Hülsen <[email protected]>
@stollero @louika
ZO-4267: deletion of collection with locked children should throw exc…
aae420b 
…eption if we do not own the lock

Co-authored-by:  Louisa v. Hülsen <[email protected]>
@louika
ZO-4267: naming things
e3476cb
@louika louika force-pushed the ZO-4267_connector_copy_move_lock branch from 4435c0f to ac01551 Compare March 6, 2024 14:06
@louika louika force-pushed the ZO-4267_connector_copy_move_lock branch from ac01551 to fb114d9 Compare March 7, 2024 09:29
@louika louika requested a review from wosc March 7, 2024 15:16
@stollero stollero force-pushed the ZO-4267_connector_copy_move_lock branch from 7e0d7aa to 432dc3e Compare March 8, 2024 08:25
@stollero stollero merged commit dd50d6f into main Mar 8, 2024
4 checks passed
@stollero stollero deleted the ZO-4267_connector_copy_move_lock branch March 8, 2024 08:55
@wosc wosc mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louika louika louika left review comments

@wosc wosc Awaiting requested review from wosc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stollero @wosc @louika