Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(ci): Check that dependencies have all been published to crates.io on release PRs #8992

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Nov 4, 2024

Motivation

We've mistakenly published a Github release that relies on crates from a git source thrice now, so we want to add a test that runs on release PRs to check that there are no git sources in the Cargo.lock file.

This is a draft PR because the test still needs to be added to CI and run for PRs that have the A-release label.

Solution

  • Adds a simple test that searches the Cargo.toml file for "source = "git+".

TODO:

  • Add a CI job for the test that runs on PRs with the A-release label

Tests

This was tested with the restore-internal-miner branch to ensure that it panics when there are dependencies being pulled in from git sources.

PR Author's Checklist

  • The PR name will make sense to users.
  • The solution is tested.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@arya2 arya2 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-testing Category: These are tests P-Low ❄️ labels Nov 4, 2024
@arya2 arya2 self-assigned this Nov 4, 2024
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Nov 4, 2024
Copy link
Member

@upbqdn upbqdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one.

@mpguerra
Copy link
Contributor

mpguerra commented Nov 6, 2024

Do we have an issue for this one? It's ok if not, we don't need to create one

@mpguerra mpguerra linked an issue Nov 6, 2024 that may be closed by this pull request
@upbqdn
Copy link
Member

upbqdn commented Nov 6, 2024

We don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.0.0-rc.0 branch CI failed: release in Release binaries
3 participants