Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clippy): Resolve new clippy lints and use renamed type from Rust std lib #8950

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Oct 18, 2024

No description provided.

@arya2 arya2 added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 18, 2024
@arya2 arya2 self-assigned this Oct 18, 2024
@arya2 arya2 requested a review from a team as a code owner October 18, 2024 22:03
@arya2 arya2 requested review from oxarbitrage and removed request for a team October 18, 2024 22:03
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint was:

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
   --> zebra-chain/src/transaction/serialize.rs:625:17
    |
625 | /                 match sapling_shielded_data {
626 | |                     Some(sd) => writer.write_all(&<[u8; 64]>::from(sd.binding_sig)[..])?,
627 | |                     None => {}
628 | |                 }
    | |_________________^ help: try: `if let Some(sd) = sapling_shielded_data { writer.write_all(&<[u8; 64]>::from(sd.binding_sig)[..])? }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
    = note: `#[warn(clippy::single_match)]` on by default

I confirmed it is fixed in this PR.

@mergify mergify bot merged commit 9073928 into main Oct 21, 2024
86 of 87 checks passed
@mergify mergify bot deleted the fix-latest-clippy-lints branch October 21, 2024 12:49
@upbqdn upbqdn mentioned this pull request Oct 25, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants