Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

book: add section about private testnet testing #8937

Merged
merged 3 commits into from
Oct 30, 2024
Merged

book: add section about private testnet testing #8937

merged 3 commits into from
Oct 30, 2024

Conversation

conradoplg
Copy link
Collaborator

@conradoplg conradoplg commented Oct 14, 2024 •
edited by arya2
Loading

Motivation

We want to document how to do a private testnet testing, so that we can more easily make another one in the future when required.

Specifications & References

Solution

Tests

Follow-up Work

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@conradoplg conradoplg requested a review from arya2 October 14, 2024 22:32
@conradoplg conradoplg requested a review from a team as a code owner October 14, 2024 22:32
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 14, 2024
mpguerra
mpguerra reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@mpguerra mpguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor typo fixes

book/src/dev/private-testnet.md Outdated Show resolved Hide resolved
book/src/dev/private-testnet.md Outdated Show resolved Hide resolved
arya2
arya2 previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation!

There aren't any blockers, I left a few minor suggestions but they can all be safely ignored.

book/src/dev/private-testnet.md Outdated Show resolved Hide resolved
book/src/dev/private-testnet.md Outdated Show resolved Hide resolved
book/src/dev/private-testnet.md Outdated Show resolved Hide resolved
book/src/dev/private-testnet.md Show resolved Hide resolved
book/src/dev/private-testnet.md Outdated Show resolved Hide resolved
book/src/dev/private-testnet.md Show resolved Hide resolved
book/src/dev/private-testnet.md Outdated Show resolved Hide resolved
@arya2 arya2 added the do-not-merge Tells Mergify not to merge this PR label Oct 26, 2024
@arya2 arya2 removed the do-not-merge Tells Mergify not to merge this PR label Oct 30, 2024
mergify bot added a commit that referenced this pull request Oct 30, 2024
@mergify
Merge of #8937
1dcd97d
@mergify mergify bot mentioned this pull request Oct 30, 2024
Closed
@mergify mergify bot merged commit 54fe39a into main Oct 30, 2024
95 checks passed
@mergify mergify bot deleted the docs-private-testnet branch October 30, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpguerra mpguerra mpguerra left review comments

@arya2 arya2 arya2 approved these changes

Assignees
No one assigned
Labels
C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conradoplg @mpguerra @arya2