-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Upgrade ECC crates for Zebra v2.0.0-rc.0
release candidate
#8918
Conversation
Note that by upgrading to those dependencies without setting the mainnet activation height, you are creating a mixed-consensus node state. I don't know how you manage that in Zebra; in |
Ok, thanks for the head-up @str4d ! However, when i tried to do it as that, it seems to be an inconsistency problem with the revisions for
|
@Pili FYI: We decided with @str4d and other ECC folks in a meeting today that we want to do the Zebra To go over #8918 (comment) other patches were also needed. I am updating the PR with all that but i think we are back in track again. |
v2.0.0-rc.0
release candidate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left a couple suggestions for cleanup and it looks like the entry for elasticsearch in the deny.toml is outdated, but there are no blockers.
Co-authored-by: Arya <[email protected]>
…date (ZcashFoundation#8918) * update ECC dependencies for release candidate * cargo vet * fix denies * fix parsing, remove not needed entries * update `secp256k1` * remove elasticsearch from denies * readd elasticsearch from deny.toml * downgrade to revisions * add more patches * typo in comment * cargo vet changes * update denies * add more git sources * Apply suggestions from code review Co-authored-by: Arya <[email protected]> * update cargo.lock --------- Co-authored-by: Arya <[email protected]>
Motivation
We need to upgrade the ECC dependencies for the next release.
This PR will also close #8809
Solution
secp256k1
now that we can and do some deny.toml cleanup.Tests
All CI tests should pass.
PR Author's Checklist
PR Reviewer's Checklist