Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): Add more fields to getmininginfo call #8860

Merged
merged 5 commits into from
Sep 18, 2024
Merged

feat(rpc): Add more fields to getmininginfo call #8860

merged 5 commits into from
Sep 18, 2024

Conversation

oxarbitrage
Copy link
Contributor

Motivation

We want to add some more fields to the getmininginfo RPC method.

Close #8858

Solution

A new ReadState::TipBlockSize was added. The rest is pretty straightforward.

Tests

Snapshot tests were updated.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@oxarbitrage oxarbitrage added C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces P-Medium ⚡ labels Sep 10, 2024
@oxarbitrage oxarbitrage requested a review from a team as a code owner September 10, 2024 22:58
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team September 10, 2024 22:58
@github-actions github-actions bot added the C-feature Category: New features label Sep 10, 2024
@oxarbitrage oxarbitrage marked this pull request as draft September 11, 2024 12:36
@oxarbitrage oxarbitrage marked this pull request as ready for review September 11, 2024 21:01
@mergify mergify bot merged commit 3f94303 into main Sep 18, 2024
192 checks passed
@mergify mergify bot deleted the getmininginfo-additional-fields branch September 18, 2024 11:05
dmidem pushed a commit to QED-it/zebra that referenced this pull request Oct 29, 2024
@oxarbitrage @dmidem
feat(rpc): Add more fields to getmininginfo call (ZcashFoundation#8860
8436b96 
)

* add additional fields to getmininginfo

* update openapi spec

* fix zebra-state standalone build

* make sure fields are not present when tip is 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn upbqdn approved these changes

Assignees
No one assigned
Labels
A-rpc Area: Remote Procedure Call interfaces C-feature Category: New features C-testing Category: These are tests P-Medium ⚡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add some missing fields to getmininginfo RPC method
2 participants
@oxarbitrage @upbqdn