Fixes lint, avoids reading coinbase transactions from disk

ZcashFoundation · Oct 25, 2024 · dfd99ab · dfd99ab
1 parent 14a225e
commit dfd99ab
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/zebra-state/src/service/finalized_state/disk_db.rs b/zebra-state/src/service/finalized_state/disk_db.rs
@@ -32,9 +32,6 @@ use crate::{
     Config,
 };
 
-#[cfg(not(feature = "indexer"))]
-use crate::constants::STATE_DATABASE_KIND;
-
 // Doc-only imports
 #[allow(unused_imports)]
 use super::{TypedColumnFamily, WriteTypedBatch};

diff --git a/zebra-state/src/service/finalized_state/disk_format/upgrade/drop_tx_locs_by_spends.rs b/zebra-state/src/service/finalized_state/disk_format/upgrade/drop_tx_locs_by_spends.rs
@@ -42,7 +42,12 @@ pub fn run(
             let height = Height(height);
             let mut batch = DiskWriteBatch::new();
 
-            for (_tx_loc, tx) in zebra_db.transactions_by_height(height) {
+            let transactions = zebra_db.transactions_by_location_range(
+                crate::TransactionLocation::from_index(height, 1)
+                    ..=crate::TransactionLocation::max_for_height(height),
+            );
+
+            for (_tx_loc, tx) in transactions {
                 if tx.is_coinbase() {
                     continue;
                 }

diff --git a/zebra-state/src/service/finalized_state/disk_format/upgrade/track_tx_locs_by_spends.rs b/zebra-state/src/service/finalized_state/disk_format/upgrade/track_tx_locs_by_spends.rs
@@ -35,7 +35,12 @@ pub fn run(
             let mut batch = DiskWriteBatch::new();
             let mut should_index_at_height = false;
 
-            for (tx_loc, tx) in zebra_db.transactions_by_height(height) {
+            let transactions = zebra_db.transactions_by_location_range(
+                crate::TransactionLocation::from_index(height, 1)
+                    ..=crate::TransactionLocation::max_for_height(height),
+            );
+
+            for (tx_loc, tx) in transactions {
                 if tx.is_coinbase() {
                     continue;
                 }