Fix Repo Link & Add Comment Length Validation #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 0.3.0
Release 0.3.1
Release 0.4.0
Release 1.0.0
Release 1.1.0 (Unsquashed)
Release 1.1.1
Release 1.2.0
Release 1.3.0
Release 1.3.1
Release 1.3.2
wbobeirne
approved these changes
Jun 6, 2019
|
I think 1K is reasonable. If we get user feedback, we can increase it. |
|
We're already seeing comments with 783 characters (see https://grants.zfnd.org/proposals/915080287-crypto-camp-in-the-south-bronx and unfortunately I can't link directly to the comment), so a 1000-character limit is definitely too low. |
|
Thanks for the feedback @tromer! We'll bump this up to 5,000 and can increase further if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #444
Part of #405
What this does
What this doesn't do
User feedback related to (2) is minimal, the textarea simply doesn't allow user to type additional characters. In the future, this could be improved by adding alerts, etc. Because this is handled by
react-mdedirectly, we'd need to build our own checker outside ofreact-mdeto determine when we should should these error messages.