WIP: Frost implementation #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We will need to have Serde support in |
3 tasks
In this commit, Chelsea and I worked through the state machines for FROST and encoded them into Rust types, leaving all functionality unimplemented. However, the protocol flow and the user-facing API is now mostly complete. Co-authored-by: Chelsea Komlo <[email protected]>
Filling in all the gaps left in this test probably reaches the point where it's better to split logic out into sub functions for each party.
This simplifies the API by skipping an extra validation step and all of the associated types.
This is already disambiguated from the frost::SecretShare by its module path, so we can avoid repeating "keygen" in the name. Users who want to ensure that it's clearly marked as a keygen share rather than a secretshare can bring it into scope as `keygen::Share` instead of `Share`.
The last remaining API issue is that the test currently can't verify the signatures it produces, because there's no way for it to compute the shared public key. Co-authored-by: Chelsea Komlo <[email protected]>
Co-authored-by: Chelsea Komlo <[email protected]>
This makes the API for key generation and signing consistent: they are both methods on `SecretShare`.
|
Closing as we've implemented a newer version of FROST in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of a FROST implementation (with @chelseakomlo).
Closes #21 when complete.
So far it has all of the state machines for all protocols encoded into the API, but the actual functions are left
unimplemented!().