Update support libraries #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adjusts the link aliases and adds a section linking to the GitHub release notes.
This drops `QueryException` in favor of `HttpError` from that library. All uses of the obsolete `UnixTime` class have been replaced with corresponding functionality of `DateTimeOffset`.
These include: - use of `is [not] null` instead of `==/!= null` or `.HasValue` - target-typed `new` - expression-valued method bodies - patterns
In the case of `ErrorInfo`, they were dropped entirely (the constructor sets them); in all other cases they were changed from `set` to `init`.
In particular, the region with `IDisposable` handling has been moved out of the `Internals` region (it includes public API so is not internal).
All methods that issue web request are now properly documented as potentially throwing `HttpRequestException` or `HttpError`.
Zastai
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
MetaBrainz.Build.Sdkto version 3.1.2,MetaBrainz.Commonto version 3.0.0 andMetaBrainz.Common.Jsonto version 6.0.1.QueryExceptionhas been dropped in favour of theHttpErrorclass provided byMetaBrainz.Common.The API docs now list it (and
HttpRequestException) as potential exceptions for methods that issue web service requests.