Fixing A_SumOfNumbers test case #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZahidFKhan
requested changes
Apr 6, 2025
| @@ -40,7 +40,7 @@ public static <T> List<T> getUniqueNumberFromList(List<T> input) { | |||
| return input.stream().distinct().toList(); | |||
| } | |||
|
|
|||
| public static long sumOfNumbers(List<Integer> input) { | |||
| public static Integer sumOfNumbers(List<Integer> input) { | |||
There was a problem hiding this comment.
The sum of the list of integers should be stored in a long or a data type with sufficient capacity to avoid potential overflow. Using an int might lead to incorrect results for larger lists.
| @@ -8,8 +8,8 @@ | |||
|
|
|||
| /* | |||
| * Given an array of {5,6,7,8,5,5,8,8,7) | |||
| * Find the sum of the unique elements. | |||
| * The output should be in this case is: 26. | |||
| * Find the sum of the all the elements. | |||
There was a problem hiding this comment.
The documentation update is clear and looks good.
| @@ -16,10 +16,10 @@ class I_SegregateEvenOddNumbers { | |||
| @Test | |||
| @Disabled | |||
| void testSegregationOfEvenOddNumbersTest() { | |||
| final var input = IntStream.range(1, 50).boxed(); | |||
| final var mySolution = NumbersProblemSolution.segregateEvenOddNumbers(input); | |||
| final var input = IntStream.range(1, 50).boxed().toList(); | |||
There was a problem hiding this comment.
Using a terminal operation here appears unnecessary and might result in slowing down of unit test case performance. We can streamline this code by keeping it within the Stream API.
|
Closing this MR as the documentation has been updated. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.