Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase #145

Merged
merged 37 commits into from
Feb 28, 2023
Merged

rebase #145

merged 37 commits into from
Feb 28, 2023

Conversation

GaetanGrd
Copy link
Collaborator

Scope

closes TICKET-###

Implementation

Screenshots

before after

How to Test

Emoji Guide

For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.

E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.

🟢 Nice refactor!

🟡 Why was the default value removed?

E.g: Blocking feedback must be addressed before merging.

🔴 This change will break something important

Blocking 🔴 ❌ 🚨 RED
Non-blocking 🟡 💡 🤔 💭 Yellow, thinking, etc
Praise 🟢 💚 😍 👍 🙌 Green, hearts, positive emojis, etc

Zagrios and others added 30 commits January 24, 2023 22:06
…n-from-available-versions-list

hotfix/no-more-files-verification-from-available-versions-list
…vailable-versions/127

bugfix/selected-effect-missing-available-versions/127
…-update

hotfix/disable-web-installer-for-update
…d-a-version

hotfix/file-verification-download-a-version
Update default-configuration.config.ts
J'ai corrigé la majorité des fautes que j'ai pu trouvé, ainsi que les problèmes de cohérence dans la mention du jeu. C'est à dire que des fois le jeu est appelé BeatSaber et des fois Beat Saber.
…rom-default-mods

hotfix/remove-model-download-from-default-mods
@GaetanGrd GaetanGrd merged commit f0f3721 into feature/readme-update Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants