Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic 3.13 support, various cleanups and version bumps #37

Merged
merged 6 commits into from
Feb 16, 2024

Conversation

jakkdl
Copy link
Contributor

@jakkdl jakkdl commented Feb 15, 2024

  • fixes Cannot import on 3.13, importlib.resources.read_text is removed #36
  • drops support for 3.8
  • now importable on 3.13
  • parso does not support 3.13, so those tests are marked with xfail
  • added 3.13-dev to CI
  • expanded tox config so it's easier to specify what python version you want to test, while leaving all previous functionality intact
  • specified base_python in the deps environment. The files were previously generated with 3.10, so left it at that, although it probably makes more sense to make that 3.9.
  • updated deps/check.txt and deps/test.txt (feels like there should be a tox -e deps call in CI to check they're up-to-date?)
  • bumped actions/checkout and actions/setup-python to latest versions
  • I did not formally specify 3.13 support in setup.py, but looking up parso now I guess hyposmith viability does not strictly depend on it having 3.13 support.
  • bumped mypy minimum version ... but it seems it's disabled in tox anyway?

@jakkdl
Copy link
Contributor Author

jakkdl commented Feb 15, 2024

@Zac-HD

Or I suppose maybe @aneeshusa and/or @thejcannon would be up for a first pass review as well.

I'm not 100% sure why test (3.8) is expected, if that's just a relic that will be cleaned up once this is properly merged, or something needs to be changed in the repo settings, or I forgot to change something somewhere.

@thejcannon
Copy link

LGTM

I'm not 100% sure why test (3.8) is expected

Where are you seeing that exactly?

@jakkdl
Copy link
Contributor Author

jakkdl commented Feb 15, 2024

2024-02-15T13:40:32,122900227+01:00

although I can't see it in https://github.com/Zac-HD/hypothesmith/pull/37/checks so it's probably just github being weird?

@thejcannon
Copy link

@Zac-HD can confirm but I suspect that's because the branch protection rules likely still reference that job name?

@Zac-HD
Copy link
Owner

Zac-HD commented Feb 15, 2024

Yep, but also 3.8 EOL isn't until October, and I'd prefer not to drop it before then. if sys.version_info[:2] ... instead?

@Zac-HD
Copy link
Owner

Zac-HD commented Feb 15, 2024

Otherwise looks good - thanks @jakkdl!

@jakkdl
Copy link
Contributor Author

jakkdl commented Feb 16, 2024

Yep, but also 3.8 EOL isn't until October, and I'd prefer not to drop it before then. if sys.version_info[:2] ... instead?

oops, brain going a bit too fast. Will do

@jakkdl jakkdl changed the title Drop python3.8, now importable on 3.13, various cleanups and version bumps ~~Drop python3.8~~ now importable on 3.13, various cleanups and version bumps Feb 16, 2024
@jakkdl jakkdl changed the title ~~Drop python3.8~~ now importable on 3.13, various cleanups and version bumps Add basic 3.13 support, various cleanups and version bumps Feb 16, 2024
Copy link
Owner

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakkdl!

@Zac-HD Zac-HD merged commit f3273dd into Zac-HD:master Feb 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import on 3.13, importlib.resources.read_text is removed
3 participants