Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some fixes for readerwriter #95

Merged
merged 25 commits into from
Feb 12, 2024
Merged

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Feb 10, 2024

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

locally, using the sample code

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Feb 10, 2024
@ptahmose ptahmose requested a review from a team February 10, 2024 00:15
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (5e5a1fc) 65.39% compared to head (15e7198) 65.97%.

Files Patch % Lines
Src/libCZI/CziReaderCommon.cpp 88.88% 6 Missing ⚠️
Src/libCZI/CZIReader.cpp 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   65.39%   65.97%   +0.57%     
==========================================
  Files          84       85       +1     
  Lines       10650    10647       -3     
==========================================
+ Hits         6965     7024      +59     
+ Misses       3685     3623      -62     
Flag Coverage Δ
windows-latest 65.97% <91.20%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

swg08
swg08 previously approved these changes Feb 11, 2024
@ptahmose ptahmose requested a review from swg08 February 11, 2024 14:00
@ptahmose ptahmose requested review from a team and swg08 February 12, 2024 08:56
Copy link

@swg08 swg08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactoring makes sense.
I haven't checked the changes line by line, but would assume that with the added tests it's made sure that the code still does what it's supposed to do. ;)

@ptahmose ptahmose merged commit b0898cb into ZEISS:main Feb 12, 2024
15 checks passed
@ptahmose ptahmose deleted the jbl/fixes_for_readerwriter branch February 12, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants