-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some fixes for readerwriter #95
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 65.39% 65.97% +0.57%
==========================================
Files 84 85 +1
Lines 10650 10647 -3
==========================================
+ Hits 6965 7024 +59
+ Misses 3685 3623 -62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refactoring makes sense.
I haven't checked the changes line by line, but would assume that with the added tests it's made sure that the code still does what it's supposed to do. ;)
Description
Type of change
How Has This Been Tested?
locally, using the sample code
Checklist: