Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option "kCurlHttp_FollowLocation" #79

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Nov 15, 2023

Description

Add two useful options to the property-bag for configuring the "curl_http_inputstream".

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

locally

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose requested a review from a team November 15, 2023 22:14
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (fac8eff) 64.47% compared to head (72d64f7) 64.46%.

Files Patch % Lines
Src/libCZI/StreamsLib/curlhttpinputstream.cpp 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   64.47%   64.46%   -0.02%     
==========================================
  Files          81       81              
  Lines       10303    10311       +8     
==========================================
+ Hits         6643     6647       +4     
- Misses       3660     3664       +4     
Flag Coverage Δ
windows-latest 64.46% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Nov 15, 2023
Copy link
Contributor

@DaveyJonesBitPail DaveyJonesBitPail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

Src/libCZI/libCZI_StreamsLib.h Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
@ptahmose ptahmose merged commit c0ff6f9 into ZEISS:main Nov 16, 2023
15 of 16 checks passed
@ptahmose ptahmose deleted the jbl/add_followlocation_option branch December 1, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants