Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for crash when libcurl is built w/o SSL-support #74

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Nov 6, 2023

Description

fix a crash when libcurl was built w/o SSL-support.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

locally

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose requested a review from a team November 6, 2023 13:18
@m-ringler m-ringler added the cla Contributor License Agreement sent to Admin label Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #74 (fdd077b) into main (8cb7ac3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   64.47%   64.47%           
=======================================
  Files          81       81           
  Lines       10303    10303           
=======================================
  Hits         6643     6643           
  Misses       3660     3660           
Flag Coverage Δ
windows-latest 64.47% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Src/libCZI/StreamsLib/curlhttpinputstream.cpp 79.67% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@ptahmose ptahmose merged commit fac8eff into ZEISS:main Nov 6, 2023
15 of 16 checks passed
@ptahmose ptahmose deleted the jbl/fix-for-crash-when-no-ssl branch November 6, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants