Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jbl/streamslib #71

Merged
merged 105 commits into from
Nov 2, 2023
Merged

Jbl/streamslib #71

merged 105 commits into from
Nov 2, 2023

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Oct 30, 2023

Description

This PR adds support for reading CZIs over an http- or https-connection. Support for http/https-stream is added to libCZI, and CZICmd is enabled to use it.

  • Infrastructure for an extensible class-factory for stream-objects is added (part of the public API).
  • An implementation of a stream-object based on libCURL is added.
  • CZICmd has been enhanced to be able to choose the stream-class to be used for reading the source.
  • Updating the build-system accordingly

Note that there are unittests (test_curlhttpstream.cpp) which access an external resource via https. Those tests take care that if the http-stream-class is not available or if there is something wrong with the connection, they report an inconclusive result rather than fail.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • unittests
  • locally running CZICmd
  • I built the library on a bunch of different systems

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose requested review from DaveyJonesBitPail, swg08 and a team November 2, 2023 11:01
Copy link

@swg08 swg08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just glanced over the PR in awe.

Copy link
Contributor

@DaveyJonesBitPail DaveyJonesBitPail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Major kudos for putting this together 😄

Copy link
Contributor

@DaveyJonesBitPail DaveyJonesBitPail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic and url-sanitation comment changes didn't change my mind :) Still approved!

@ptahmose ptahmose merged commit 069e621 into ZEISS:main Nov 2, 2023
15 checks passed
@ptahmose ptahmose deleted the jbl/streamslib branch November 2, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants