-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jbl/streamslib #71
Jbl/streamslib #71
Conversation
Co-authored-by: DaveyJonesBitPail <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I just glanced over the PR in awe.
Co-authored-by: DaveyJonesBitPail <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Major kudos for putting this together 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cosmetic and url-sanitation comment changes didn't change my mind :) Still approved!
Description
This PR adds support for reading CZIs over an http- or https-connection. Support for http/https-stream is added to libCZI, and CZICmd is enabled to use it.
Note that there are unittests (test_curlhttpstream.cpp) which access an external resource via https. Those tests take care that if the http-stream-class is not available or if there is something wrong with the connection, they report an inconclusive result rather than fail.
Type of change
How Has This Been Tested?
Checklist: