Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jbl/lax parsing special case #64

Merged
merged 7 commits into from
Sep 4, 2023

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Sep 4, 2023

Description

This is following up on #63 , and adds a more fine-grained control over what is checked for in "strict parsing".
In particular, it turned out that quite a few CZI-documents exist where "SizeM" for a pyramid-subblock was >1. So, we want to exclude this error from "strict parsing", at least optionally, as this fluke can be safely ignored.

  • add infrastructure for fine-grained control of parsing
  • add option to ignore "SizeM>1 on pyramid-subblocks" to the public API
  • (just a few unrelated) typos fixed

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe the tests that you ran to verify your changes.
Provide instructions to reproduce.

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose marked this pull request as ready for review September 4, 2023 08:14
@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #64 (6bc6f1e) into main (1d26fe8) will increase coverage by 0.10%.
The diff coverage is 87.69%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   50.13%   50.23%   +0.10%     
==========================================
  Files          77       78       +1     
  Lines       16044    16088      +44     
==========================================
+ Hits         8043     8082      +39     
- Misses       8001     8006       +5     
Flag Coverage Δ
windows-latest 50.23% <87.69%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
Src/libCZI/CziReaderWriter.cpp 79.88% <ø> (ø)
Src/libCZI/libCZI.h 100.00% <ø> (ø)
Src/libCZI/CZIReader.cpp 65.51% <69.23%> (-0.47%) ⬇️
Src/libCZI/CziParse.cpp 71.55% <88.23%> (+0.91%) ⬆️
Src/libCZI/CziParse.h 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ptahmose ptahmose merged commit 4a3533f into ZEISS:main Sep 4, 2023
15 checks passed
@ptahmose ptahmose deleted the jbl/lax_parsing_special_case branch November 6, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants