Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename accountURL for consistency #119

Merged
merged 11 commits into from
Oct 9, 2024

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Oct 8, 2024

Description

  • fixed documentation to state the same string as expected in code
  • add error handling to AzureBlobInputStream::Read method

Fixes #118

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

locally

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Updated CMakeLists.txt to increment project version from 0.62.4 to 0.62.5.
Renamed key accountURL to accounturl in stream_objects.markdown and
azureblobinputstream.h to maintain consistent naming conventions.
@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Oct 8, 2024
@ptahmose ptahmose requested a review from a team October 8, 2024 11:13
@ptahmose ptahmose requested review from DaveyJonesBitPail and a team October 8, 2024 21:31
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.47%. Comparing base (6fb48d5) to head (9835acf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Src/libCZI/StreamsLib/azureblobinputstream.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   65.50%   65.47%   -0.04%     
==========================================
  Files          86       86              
  Lines       10893    10898       +5     
==========================================
  Hits         7136     7136              
- Misses       3757     3762       +5     
Flag Coverage Δ
windows-latest 65.47% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Introduce error handling for AzureBlobInputStream::Read. If ptrBytesRead is nullptr, construct an error message using ostringstream and throw a runtime_error indicating 'DownloadTo' operation failure with status code.
@ptahmose ptahmose merged commit 515abf6 into ZEISS:main Oct 9, 2024
15 checks passed
@ptahmose ptahmose deleted the jbl/#118_fix_accounturl branch October 9, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mismatch between documentation and implementation (regarding spelling of a string constant)
2 participants