Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build when using a private RapidJSON library #117

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

ptahmose
Copy link
Contributor

Description

The CMake-build failed when using a private RapidJSON-library (i.e. when LIBCZI_BUILD_PREFER_EXTERNALPACKAGE_RAPIDJSON would be false) when attempting to clone the repository because when specifying "GIT_SHALLOW TRUE" it is not possible to use a git-hash as tag. C.f. here.
This removes the GIT_SHALLOW specifier, and while at it, switches to the latest version.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

locally

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Sep 26, 2024
@ptahmose ptahmose requested a review from a team September 26, 2024 04:45
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.50%. Comparing base (6b0fbc9) to head (f38bd22).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   65.50%   65.50%           
=======================================
  Files          86       86           
  Lines       10893    10893           
=======================================
  Hits         7136     7136           
  Misses       3757     3757           
Flag Coverage Δ
windows-latest 65.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptahmose ptahmose merged commit 6fb48d5 into ZEISS:main Sep 26, 2024
15 of 16 checks passed
@ptahmose ptahmose deleted the jbl/fix_for_private_rapidjson branch September 26, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants