Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Playwright driver 1.48.0 #310

Merged
merged 6 commits into from
Nov 3, 2024
Merged

Update Playwright driver 1.48.0 #310

merged 6 commits into from
Nov 3, 2024
+5,678 −6,969

Conversation

YusukeIwaki
Copy link
Owner

resolves #308

@vercel Vercel
Copy link

vercel bot commented Oct 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
playwright-ruby-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 5:10pm

@YusukeIwaki
Copy link
Owner Author

update_api.rb should include this change microsoft/playwright#32510

@YusukeIwaki YusukeIwaki marked this pull request as ready for review November 3, 2024 16:43
YusukeIwaki
YusukeIwaki commented Nov 3, 2024
View reviewed changes
development/generate_api/renderers/apidoc_renderer.rb
data << ''
data << @comment_converter.convert(@method_with_doc.method_deprecated_comment)
data << ''
data << ":::"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-11-04 at 02 10 47@2x

YusukeIwaki
YusukeIwaki commented Nov 3, 2024
View reviewed changes
development/generate_api/renderers/playwright_api_renderer.rb
@@ -231,6 +231,10 @@ def render_lines
@method_with_doc.method_comment&.split("\n")&.each do |line|
data << "# #{line}"
end
if @method_with_doc.method_deprecated_comment
data << '#'
data << "# @deprecated #{@method_with_doc.method_deprecated_comment}"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-11-04 at 02 11 22@2x

@YusukeIwaki YusukeIwaki merged commit cc37b97 into main Nov 3, 2024
16 of 19 checks passed
@YusukeIwaki YusukeIwaki deleted the driver/1.48.0 branch November 3, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to Playwright 1.48.0
1 participant
@YusukeIwaki