cmake, add check on FUZZ_LDFLAGS #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDVG
reviewed
Dec 6, 2024
The invocation of cmake with -DFUZZ=ON will produce an error:
set_target_properties called with incorrect number of arguments.
The error is due to the fact that the FUZZ_LDFLAGS variable needs
to be defined and non-empty to be correctly supplied in the
set_target_properties() invocations that follow the introduced
assertion.
See also:
https://cmake.org/cmake/help/latest/command/set_target_properties.html
dacav
force-pushed
the
dacav/cmake-fix
branch
from
6b739d4 to
0b92461
Compare
LDVG
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triviality, but it avoids triggering more "obscure" errors.