Added support for XStringSet in msaplot #631
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for XStringSet objects (i.e.,
BStringSet
,AAStringSet
andDNAStringSet
) for functionmsaplot()
in response to #626. The problem came up because an old example on R-Bloggers does not work anymore.In the proposed solution, if the object is of type
BStringSet
it is first checked, if libraryBiostrings
is installed. If so, a temporary file is created and read viatreeio::read.fasta()
to circumvent the need to check if it as amino acid or DNA sequence. Otherwise it throws a helpful error message.AAStringSet
andDNAStringSet
objects are converted using functions from theape
package.Tests
The function produces the expected outcome: