Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gs 1995 fix crontab #247

Closed
wants to merge 3 commits into from
Closed

Gs 1995 fix crontab #247

wants to merge 3 commits into from

Conversation

pniel-cohen
Copy link
Collaborator

  • GS-1995,YOTPO-168: Removed unused Cron classes & pointed 'yotpo_yotpo_update_metadata' to the corresponding Model\Jobs\UpdateMetadata

sharp80 and others added 3 commits March 12, 2020 18:50
@sharp80
Merge pull request #229 from YotpoLtd/addCspWhitelist
85be35e 
Added CSP whitelist
Changed cron class UpdateMetadata to UpdateMetadataJob to align with …
dfc6c5a 
…it's class name. Should solve GH issue #228
GS-1995,YOTPO-168: Removed unused Cron classes & pointed 'yotpo_yotpo…
581f9e6 
…_update_metadata' to the corresponding Model\Jobs\UpdateMetadata
@pniel-cohen
Copy link
Collaborator Author

I just noticed that the classes under the Cron dir are not being used, so I removed them & pointed the job to the relevant model.

@pniel-cohen pniel-cohen mentioned this pull request Apr 27, 2020
Closed
@fredden
Copy link

fredden commented Apr 27, 2020

This is a duplicate of #236.

@fredden fredden mentioned this pull request Apr 27, 2020
Closed
@lgreenboim lgreenboim closed this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pniel-cohen @fredden @lgreenboim @sharp80