updates method to domain identifier

YorCreative · Aug 22, 2024 · 9b6f9f5 · 9b6f9f5
1 parent 12a3349
commit 9b6f9f5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Repositories/UrlRepository.php b/src/Repositories/UrlRepository.php
@@ -137,7 +137,7 @@ public static function findByIdentifier(string $identifier): ?ShortUrl
         )->with(self::defaultWithRelationship())->first();
     }
 
-    public static function findByDomainIdentifier(?string $domain, string $identifier): ?ShortUrl
+    public static function findByDomainIdentifier(string $domain, string $identifier): ?ShortUrl
     {
         return ShortUrl::where('identifier', $identifier)
             ->where('domain', $domain)

diff --git a/src/Services/ClickService.php b/src/Services/ClickService.php
@@ -57,7 +57,7 @@ public static function track(string $identifier, string $request_ip, int $outcom
 
         try {
             ClickRepository::createClick(
-                UrlRepository::findByIdentifier($identifier, $domain)->id,
+                UrlRepository::findByDomainIdentifier($domain, $identifier)->id,
                 LocationRepository::findOrCreateLocationRecord(
                     ! config('location.testing.enabled')
                         ? LocationRepository::getLocationFrom($request_ip)