Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #1

Closed
wants to merge 2 commits into from
Closed

Improvements #1

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 11, 2021

i'm still not finished! please have it reviewed

this PR will allow to support more distributions other than alpine. using proot-distro as an engine

by default it will use alpine, by setting CNF_OS_TYPE variable to debian or arch will use that distribution

for remote uninstallation, just specify export CNF_UNINSTALL=1 to trigger uninstallation of the distribution

and to disable. specify CNF_DISABLE=1 variable

@Yonle Yonle added the enhancement New feature or request label Sep 11, 2021
@Yonle
Copy link
Owner

Yonle commented Sep 11, 2021

Well. That would better to do something else. Gonna test it out.

Copy link
Owner

@Yonle Yonle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command-not-found is better to put it to install.sh script. To be clever, The command-not-found code should be inside install.sh file instead.

@ghost
Copy link
Author

ghost commented Sep 11, 2021

maybe though i thought it would be better for install.sh to install files in directories

@Yonle
Copy link
Owner

Yonle commented Sep 11, 2021

Well, maybe writting those all fish script inside install.sh would OK. I may check it later

@Yonle Yonle marked this pull request as draft September 11, 2021 11:05
@Yonle
Copy link
Owner

Yonle commented Sep 19, 2021

Closing due to inactivity. You may open new PR once you're done

@Yonle Yonle closed this Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant