Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve I18N Issues (Based on 1.17) #224

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

alexclassroom
Copy link
Contributor

@alexclassroom alexclassroom commented Jan 27, 2024

Summary

This PR can be summarized in the following changelog entry:

  • Improves translation handling for post types registration and indexation reset. Props to @alexclassroom.

Relevant technical choices:

Milestone

  • I've attached the next release's milestone to this pull request.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Basically a regression test since strings may not be there (and definitely the second one isn't since it's new)

  • Enable the custom post types (Books and Movies)
  • check that you still see "Add new" in their submenus
  • reset indexables and migrations
  • visit the Yoast SEO General page and see that you get a notification saying Because some of your SEO data was reset by the Yoast Test Helper, your SEO data needs to be reprocessed.

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Fixes #

@enricobattocchi enricobattocchi self-assigned this Jan 29, 2024
@enricobattocchi enricobattocchi changed the base branch from develop to release/1.18 January 29, 2024 08:48
@enricobattocchi enricobattocchi added this to the 1.18 milestone Jan 29, 2024
@enricobattocchi enricobattocchi merged commit 4dc4e92 into Yoast:release/1.18 Jan 29, 2024
7 checks passed
@enricobattocchi
Copy link
Member

Thanks @alexclassroom! We're adding this to the upcoming 1.18 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants