Feature/update di container #21905
Open
Feature/update di container #21905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijsoo
added
the
changelog: non-user-facing
composer.lockDev Package changes
Settings · Docs · Powered by Private Packagist |
Pull Request Test Coverage Report for Build ecfb1c899b77260070bc0eeff3475cb45190f99dDetails
💛 - Coveralls |
thijsoo
force-pushed
the
feature/update-di-container
branch
from
a6de0f5 to
a67113f
Compare
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
…pdate-di-container # Conflicts: # composer.lock
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
|
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
…pdate-di-container # Conflicts: # composer.json # composer.lock
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Important
Take not this PR needs to be merged together with https://github.com/Yoast/wordpress-seo-local/pull/2554
Also take a look at the source issue for linked in this PR for more next steps when we are merging this.
Summary
This PR can be summarized in the following changelog entry:
symfony/dependency-injectionpackage to version 5.4Relevant technical choices:
To make this work I needed to make a couple of changes. The first change was to also include some new files in our
php-scoperwhich are located inconfig/php-scoper/service-contracts.inc.phpthese files are needed for the DI container to compile so we need them to be copied over in our scoper.The second change made was to mark
src/introductions/infrastructure/introductions-seen-repository.phpas@makePublic. This is needed because with this update the default behavior for new classes that live inFreeand are used in any addon + premium is to be marked aspublic(false). This means that they are not included in the DI containers public classes. Which in practical terms means thatYoastSEO()->classes->get('...')no longer works. We want this since we do not want our entire codebase to be public API.This has no affect on existing classes which are located in folders that are included in the list in
/config/dependency-injection/loader-pass.phpin theprocess_definitionmethod.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
composer require yoast/wordpress-seo:"dev-feature/update-di-container@dev as dev-release/24.8@dev" --devFor premium you just need:
composer require yoast/wordpress-seo:"dev-feature/update-di-container@dev as dev-release/24.8@dev"Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #