Skip to content

Make use of plugin channels instead of sockets connections #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make use of plugin channels instead of sockets connections #12

wants to merge 1 commit into from

Conversation

TuxCoding
Copy link

First I want that you make a feedback on this before I continue working on it, because it's a lot of work to do. Maybe you can help too, because some fields are very unclear.

Summary what I did:

  • Use plugin channels completely
  • Replaced some threads with Runnables
  • Now stores the bytes instead of message
  • Replaced tabs with spaces
  • make single usage more universal

@HeroCC
Copy link

HeroCC commented Aug 31, 2016

Won't this only run with players on the server? I thought that was a limitation of Plugin Channels.

@TuxCoding
Copy link
Author

That's correct, but as I understand your implementation it does the same. Your implementation starts a new socket connection once a player joins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants