New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use handleUnaryRequest for replication server methods #769

Merged

aprudhomme merged 1 commit into Yelp:main from aprudhomme:use_unary_request_helper_more

Oct 21, 2024

Contributor

aprudhomme commented Oct 21, 2024

Use the handleUnaryRequest utility method where applicable for the replication server.

Also:

For the methods that cannot use this, I tried to make error handling more consistent
Made sure handlers are using the getIndexState and getIndexStateManager versions that throw NOT_FOUND status
Other logging cleanup


          Use handleUnaryRequest for replication server methods

c40ca1c

aprudhomme requested a review from sarthakn7

October 21, 2024 17:02

sarthakn7 approved these changes

View reviewed changes

aprudhomme merged commit a83cf2f into Yelp:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet