-
Notifications
You must be signed in to change notification settings - Fork 36
Link to love recipients explore page after sending love. #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rockdog
wants to merge
1
commit into
Yelp:master
Choose a base branch
from
rockdog:link-recipients
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# -*- coding: utf-8 -*- | ||
import unittest | ||
|
||
from testing.util import get_test_app | ||
from util.markup import explore_links | ||
|
||
|
||
class ExploreLinksTest(unittest.TestCase): | ||
"""Tests util.email.explore_links()""" | ||
|
||
def setUp(self): | ||
self.app = get_test_app().app | ||
self.app.config.update(SERVER_NAME='foo.com') | ||
self.app_context = self.app.app_context() | ||
self.app_context.push() | ||
|
||
def tearDown(self): | ||
self.app.config.update(SERVER_NAME=None) | ||
self.app_context.pop() | ||
|
||
def test_empty_list(self): | ||
self.assertEqual(explore_links([], self.app_context), []) | ||
|
||
def test_explore_links(self): | ||
links = explore_links(['darwin'], self.app_context) | ||
self.assertEqual(links, ['<a href="http://foo.com/explore?user=darwin">darwin</a>']) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# -*- coding: utf-8 -*- | ||
from dominate.tags import a | ||
from flask import url_for | ||
|
||
|
||
def explore_links(employees, app_context): | ||
with app_context: | ||
return [ | ||
a(employee, href=url_for('explore', user=employee)).render() | ||
for employee in employees | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan on making more use of this in the future, e.g. for manipulating the DOM? It seems overkill to add the library just to generate
<a href="...">...</a>
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. I can‘t say right now.
I just didn‘t feel like building tag(s) myself and re-implementing the wheel. And since this lib seems kind of maintained and has no other dependencies I felt okay adding it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are you reimplementing the wheel?
I'm generally wary of adding these kinds of dependencies, it's just one more thing to maintain that adds bloat to our project. And it's not like a) we expect changes to how a tags are built that this package will cover for us; or b) that we not already have folders full of HTML. I consider this a general feeling of not wanting to put HTML markup in a "code" file, while the library just hides the fact that you do this.