Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer getfullargspec instead of deprecated getargspec #485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prefer getfullargspec instead of deprecated getargspec #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tests/testing/response_mocks_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# -*- coding: utf-8 -*-
import inspect
try:
from inspect import getfullargspec as getargspec
except ImportError:
from inspect import getargspec

import mock
import pytest
Expand Down Expand Up @@ -32,10 +35,10 @@ def mock_metadata():

def test_response_mock_signatures():
"""Make sure the mocks' __call__ methods have the same signature as HttpFuture.response"""
response_signature = inspect.getargspec(HttpFuture.response)
response_signature = getargspec(HttpFuture.response)

assert inspect.getargspec(BravadoResponseMock.__call__) == response_signature
assert inspect.getargspec(FallbackResultBravadoResponseMock.__call__) == response_signature
assert getargspec(BravadoResponseMock.__call__) == response_signature
assert getargspec(FallbackResultBravadoResponseMock.__call__) == response_signature


def test_bravado_response(mock_result):
Expand Down