Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix negative value check for non-retryable exit codes in Kubernetes configuration #995

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Fix negative value check for non-retryable exit codes in Kubernetes configuration #995

merged 2 commits into from
Sep 9, 2024

Conversation

cuza
Copy link
Member

@cuza cuza commented Sep 5, 2024 •
edited
Loading

This pull request fixes a bug in the Kubernetes configuration where a negative value was not properly checked for non-retryable exit codes.

nemacysts
nemacysts approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@nemacysts nemacysts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be nice to add a test in tests/config/config_parse_test.py - but this code is pretty simple

@jfongatyelp
Copy link
Contributor

might be nice to add a test in tests/config/config_parse_test.py - but this code is pretty simple

++, would definitely be nice

@cuza cuza merged commit d1db4c4 into master Sep 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfongatyelp jfongatyelp jfongatyelp approved these changes

@nemacysts nemacysts nemacysts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cuza @jfongatyelp @nemacysts