Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix under python 3.11+ #350

Merged
merged 3 commits into from
Oct 3, 2023
Merged

fix under python 3.11+ #350

merged 3 commits into from
Oct 3, 2023

Conversation

benbariteau
Copy link
Member

@benbariteau benbariteau commented Oct 3, 2023 •
edited
Loading

  • imp was removed in python 3.12, so this replaces usages. I also added a minimum python version of 3.8 as a result.
  • The traceback format was changed in python 3.11, so I had to fix a test for that.

@benbariteau benbariteau force-pushed the fix_tests_under_py3.11 branch 16 times, most recently from 922c456 to 1a4279a Compare October 3, 2023 21:22
@benbariteau benbariteau force-pushed the fix_tests_under_py3.11 branch from 1a4279a to 9454869 Compare October 3, 2023 21:27
@benbariteau benbariteau changed the title fix test_discover_test_with_broken_import under python 3.11+ fix under python 3.11+ Oct 3, 2023
@benbariteau benbariteau marked this pull request as ready for review October 3, 2023 21:28
@benbariteau benbariteau merged commit 9454869 into Yelp:master Oct 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielpops danielpops danielpops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benbariteau @danielpops