Skip to content

Commit

Permalink
Disable compilation signing process, since this causes issues with so…
Browse files Browse the repository at this point in the history
…me of the dependencies which are not using strong names
  • Loading branch information
Frooxius committed Nov 17, 2023
1 parent 70ec1f9 commit d0cad5c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions CSCore/CSCore.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,7 @@
<SignAssembly>false</SignAssembly>
</PropertyGroup>
<PropertyGroup>
<AssemblyOriginatorKeyFile>
</AssemblyOriginatorKeyFile>
<AssemblyOriginatorKeyFile>cscore.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>
<ItemGroup>
<Reference Include="Microsoft.Win32.Primitives, Version=4.0.2.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
Expand All @@ -113,7 +112,7 @@
</Reference>
<Reference Include="NVorbis, Version=0.10.4.1, Culture=neutral, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\..\NVorbis\NVorbis\bin\Release\netstandard2.0\NVorbis.dll</HintPath>
<HintPath>..\..\NVorbis\NVorbis\bin\Release\net462\NVorbis.dll</HintPath>
</Reference>
<Reference Include="System" />
<Reference Include="System.AppContext, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
Expand Down
4 changes: 2 additions & 2 deletions Tools/CSCli/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,12 @@ private static void Main(string[] args)
WriterParameters wp = new WriterParameters();
ReaderParameters rp = new ReaderParameters();

var strongNameKey = Path.ChangeExtension(filename, "snk");
/*var strongNameKey = Path.ChangeExtension(filename, "snk");
if (File.Exists(strongNameKey))
{
MessageIntegration.Info("Signing with Key : " + strongNameKey);
wp.StrongNameKeyPair = new StrongNameKeyPair(File.OpenRead(strongNameKey));
}
}*/

//check whether the pdbfile has been passed through application parameters
if (pdbfile == null)
Expand Down

0 comments on commit d0cad5c

Please sign in to comment.