WIP: Bugfix: 'NoneType' object has no attribute 'get_transport' #227
Conversation
- partly refactored method `ClouderModel.__execute` - `SSHEnvironment.__getattr__`: if we define getattr we do not need to call *super* method, because __getattr__ is called only if attribute is not found by other methods, such as: __dict__ lookup, __getattribute__, etc. - [SO question](http://stackoverflow.com/questions/3278077/difference-between-getattr-vs-getattribute) - [Py documentation](https://docs.python.org/2/reference/datamodel.html#object.__getattr__)
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 33.16% 33.28% +0.11%
==========================================
Files 52 52
Lines 3902 3888 -14
==========================================
Hits 1294 1294
+ Misses 2608 2594 -14
Continue to review full report at Codecov.
|
| @@ -213,10 +213,6 @@ def __init__(self, *args, **kwargs): | |||
|
|
|||
| def __getattr__(self, key): | |||
| """ Provide passthrough to paramiko Client while locking the conn """ | |||
| try: | |||
There was a problem hiding this comment.
Without this, all attributes for the SSHEnvironment object will be inaccessible. This try/except block first attempts attributes on the current object, then escalates to paramiko. Did you run into some sort of name conflict or something?
There was a problem hiding this comment.
No name conflicts, just attempt to make code cleaner and simpler...
I have some experience with __getattr__ and __getattribute__ method in few of my projects.
For example this and this do same thing, and both working.
__getattr__ method is called only if attribute is not found in usual way. Thus all normal attributes of SSHEnvironment object will be accessible. The super call is required if __getattribute__ method is used.
Simple repl test:
class MyObject(object):
def __init__(self, obj):
self.attr = 42
self.obj = obj
def __getattr__(self, name):
return getattr(self.obj, name)
class C2(object):
def __init__(self):
self.obj_attr = 81
obj = MyObject(C2())
print obj.attr # output: 42
print obj.obj_attr # output: 81May be i have something missed?
Also i can revert this change in next commit...
Hello!
This is mostly bugfix PR, but I want also do some more refactoring of
__executemethod.Can I do it in this PR? Or it is better to create separate PR?
Changes
ClouderModel.__executeSSHEnvironment.__getattr__: if we define getattr we do not need tocall super method, because getattr is called only if attribute is
not found by other methods, such as: dict lookup, getattribute,
etc.
Plans
ClouderModel.__execute_execute, this allow to override it in inherited models, especiallycolouder.serviceClouderServicetoclouder.servicemodel (this allow to avoid strange ifs likeif self._name == 'clouder.service')cmdarg to separate method